Skip to content

fix: Do not bump neighbours mid-drag#9977

Merged
maribethb merged 1 commit into
RaspberryPiFoundation:v13from
mikeharv:no-dragging-bumps
Jun 11, 2026
Merged

fix: Do not bump neighbours mid-drag#9977
maribethb merged 1 commit into
RaspberryPiFoundation:v13from
mikeharv:no-dragging-bumps

Conversation

@mikeharv

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes

Proposed Changes

This makes me two adjustments to how blocks are positioned during startDrag, at the start of a keyboard move:

  1. Dragging blocks will no longer be bumped or have their neighbours bumped. If a top block is moved off of its stack, the other blocks will stay put; similar to command+dragging a single block off the top of a stack.
image image
  1. Newly dragging blocks will use the same offset/positioning logic as blocks that are mid-drag. We offset the location so that it reveals both the insertion marker and candidate connecting block. If the dragging block is becoming a child, we offset to the lower right. If the dragging block is becoming a parent, we offset to the upper left.
    imageimage

Reason for Changes

As of the latest v13 beta.9, pressing M to move a block causes the selected block and any neighbour to move in unexpected ways due to bumping. The preview position of the dragging block was also inconsistent with later moves within the same "drag".

image image

@mikeharv mikeharv requested a review from a team as a code owner June 11, 2026 19:28
@mikeharv mikeharv requested a review from maribethb June 11, 2026 19:28
@github-actions github-actions Bot added the PR: fix Fixes a bug label Jun 11, 2026

@maribethb maribethb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maribethb maribethb merged commit 79eeb9d into RaspberryPiFoundation:v13 Jun 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants