fix: reset initial connections before storing new ones#9982
Merged
mikeharv merged 2 commits intoJun 12, 2026
Conversation
maribethb
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes:
Proposed Changes
This change guarantees that we clear any stored initial connections before storing new ones.
Reason for Changes
The workspace could become completely unresponsive if a revert fails. In this case, after storing an initial child connection, the block was moved to a parent connection on the same block. When the next move occurs, the initial child connection was not cleared, resulting in two conflicting initial connections. Revert would then try to "re-connect" the blocks in two conflicting ways.
Test Coverage
Thanks to @maribethb for writing a new test that ensures we don't throw when a block move is reverted after storing both a child and parent connection for two different moves.
Additional Information
Alternative to #9980
It still seems like there is some cleanup that is missing (that
endDragdoes butrevertDragdoesn't, but this can wait for now.