fix: Fix bug that could prevent dismissing field editors on Enter#9986
Open
gonfunko wants to merge 2 commits into
Open
fix: Fix bug that could prevent dismissing field editors on Enter#9986gonfunko wants to merge 2 commits into
gonfunko wants to merge 2 commits into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR prevents propagation of the Enter event in a field editor. For
FieldDate, this prevented Enter from dismissing the date picker; although Enter committed the change and hid the picker, the global Enter keyboard shortcut was subsequently invoked and put the field back into editing mode. By stopping propagation, we prevent the keyboard shortcut from being invoked and causing unexpected side effects.