fix: MiniMax stubs, PKCE cleanup, driver defaults, sandbox tests#1116
Open
AlexZander85 wants to merge 2 commits intoRightNow-AI:mainfrom
Open
fix: MiniMax stubs, PKCE cleanup, driver defaults, sandbox tests#1116AlexZander85 wants to merge 2 commits intoRightNow-AI:mainfrom
AlexZander85 wants to merge 2 commits intoRightNow-AI:mainfrom
Conversation
…with vault token persistence
Adds a new oauth_providers module with device-flow implementations for
OpenAI Codex, Google Gemini, Qwen (DashScope), and MiniMax. Tokens are
persisted to both the in-memory vault and secrets.env for dual-write
durability. The Copilot flow is preserved unchanged.
New routes:
POST /api/providers/openai-codex/oauth/start
GET /api/providers/openai-codex/oauth/poll/{poll_id}
POST /api/providers/gemini-oauth/oauth/start
GET /api/providers/gemini-oauth/oauth/poll/{poll_id}
POST /api/providers/qwen-oauth/oauth/start
GET /api/providers/qwen-oauth/oauth/poll/{poll_id}
POST /api/providers/minimax-oauth/oauth/start
GET /api/providers/minimax-oauth/oauth/poll/{poll_id}
UI: Settings page shows Login buttons for each provider with device-code
display and polling feedback.
- Replace MiniMax dead-code Ok branches with minimal stub implementations + TODO - Add State(_state) to minimax_oauth_poll for future token persistence - Remove unused PKCE generate_pkce/generate_state functions and their tests - Clean up doc comments (remove redundant blank lines, update module description) - Fix copilot provider_defaults: key_required=false (uses OAuth, not API key) - Add vertex-ai provider_defaults (GOOGLE_APPLICATION_CREDENTIALS) - Add 4 OAuth provider_defaults tests (codex, gemini, qwen, minimax) - Add copilot + vertex-ai provider_defaults tests - Add 2 shell-wrapper regression tests in subprocess_sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_pkce/generate_statefunctions and their tests fromoauth_providers.rsprovider_defaultstests (codex, gemini, qwen, minimax, copilot, vertex-ai)subprocess_sandbox.rsOkbranches with minimal stub implementations + TODO comments (Rust requires exhaustive match)key_required=false, vertex-ai default port 8600Changed files
crates/openfang-runtime/src/oauth_providers.rs- PKCE removal, doc comment cleanupcrates/openfang-runtime/src/drivers/mod.rs- copilot key_required, vertex-ai defaults, 6 provider_defaults testscrates/openfang-runtime/src/subprocess_sandbox.rs- 2 shell-wrapper testscrates/openfang-api/src/routes.rs- MiniMax stub implementationsTest plan
cargo build --workspace --lib- compiles cleancargo test -p openfang-api -p openfang-runtime -p openfang-types- all 910+ tests passcargo clippy --workspace --all-targets -- -D warnings- zero warningsPart of #1030 OAuth providers review split (PR 2 of 3)