feat: click TOC entries to jump to section#184
Merged
Conversation
Owner
|
Hi @giovannipapini A couple of requests:
GPG signing docs : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
c8766c8 to
e7a71e5
Compare
Contributor
Author
|
Hi @RivoLink, thanks for the review! All done:
Ready for another look whenever you have a moment. |
3060fa8 to
b520614
Compare
Owner
|
Hi, |
Owner
|
No worries about the cargo audit. |
Owner
|
I’m on it. I may need you to rebase after my fix. |
Owner
|
Hi @giovannipapini |
b520614 to
41d6b01
Compare
Owner
|
Perfect, thank you so much 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.toc_area(same pattern ascontent_area)toc_display_to_toc_indexmap insiderefresh_toc_cacheso each visible display row maps back to itstocentryscroll_to_toc_display_line(display_idx)onAppTest plan
tto show the TOC1–9) navigation still works unchangedCloses #183