chore: bump criterion to 0.8.2#110
Open
jgabaut wants to merge 1 commit intoRobbepop:masterfrom
Open
Conversation
jgabaut
commented
May 6, 2026
jgabaut
commented
- Closes Criterion is out of date #107
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 61.06% 61.06%
=======================================
Files 12 12
Lines 506 506
=======================================
Hits 309 309
Misses 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xtqqczze
reviewed
May 6, 2026
Contributor
xtqqczze
left a comment
xtqqczze
left a comment
There was a problem hiding this comment.
rust-version = "1.85.0"
The library builds successfully with Rust 1.85, so we could just say a more recent compiler is required for benchmarks.
xtqqczze
reviewed
May 6, 2026
jgabaut
changed the title
xtqqczze
approved these changes
May 6, 2026
Contributor
xtqqczze
left a comment
xtqqczze
left a comment
There was a problem hiding this comment.
I guess this is fine if having the latest dev-dependencies is important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.