primeorder: faster lincomb_vartime when alloc enabled#1758
Merged
Conversation
Companion PR to RustCrypto/group#14, which adds `WnafBase::multiscalar_mul` using Straus' method. When the `alloc` feature is enabled, this is used to compute `LinearCombination::lincomb_vartime`. Also includes updated tests and benchmarks for `p256` to ensure `lincomb_vartime` computes the same results as using the `Add` and `Mul` traits, and show the relative performance improvement, which is a ~28% speedup on `p256` for a 3 scalar/point input: ProjectivePoint operations/point-scalar lincomb (variable-time) time: [149.13 µs 149.80 µs 150.84 µs] change: [−27.999% −27.645% −27.267%] (p = 0.00 < 0.05)
tarcieri
force-pushed
the
primeorder/faster-lincomb-vartime
branch
from
42466ca to
5590b8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to RustCrypto/group#14, which adds
WnafBase::multiscalar_mulusing Straus' method.When the
allocfeature is enabled, this is used to computeLinearCombination::lincomb_vartime.Also includes updated tests and benchmarks for
p256to ensurelincomb_vartimecomputes the same results as using theAddandMultraits, and show the relative performance improvement, which is a ~28% speedup onp256for a 3 scalar/point input: