Skip to content

fix: get command now uses deduplication manager for chunk retrieval #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kpj2006 wants to merge 1 commit into from
Closed

fix: get command now uses deduplication manager for chunk retrieval #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions cmd/get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (

"github.com/substantialcattle5/sietch/internal/compression"
"github.com/substantialcattle5/sietch/internal/config"
"github.com/substantialcattle5/sietch/internal/deduplication"
"github.com/substantialcattle5/sietch/internal/encryption"
"github.com/substantialcattle5/sietch/internal/fs"
"github.com/substantialcattle5/sietch/internal/progress"
Expand Down Expand Up @@ -163,6 +164,12 @@ Example:
return fmt.Errorf("failed to get passphrase: %v", err)
}

// Initialize deduplication manager
dedupManager, err := deduplication.NewManager(vaultRoot, vaultConfig.Deduplication)
if err != nil {
return fmt.Errorf("failed to initialize deduplication manager: %v", err)
}

// Create progress manager
progressMgr := progress.NewManager(progress.Options{
Quiet: quiet,
Expand Down Expand Up @@ -204,18 +211,11 @@ Example:
chunkHash = chunkRef.EncryptedHash
}

// Get the chunk path
chunkPath := filepath.Join(vaultRoot, ".sietch", "chunks", chunkHash)

// Check if chunk exists
if _, err := os.Stat(chunkPath); os.IsNotExist(err) {
return fmt.Errorf("chunk %s not found", chunkHash)
}

// Read the chunk data
chunkData, err := os.ReadFile(chunkPath)
// Read the chunk data using deduplication manager
// This properly resolves chunks through the deduplication index
chunkData, err := dedupManager.GetChunk(chunkHash)
if err != nil {
return fmt.Errorf("failed to read chunk: %v", err)
return fmt.Errorf("failed to read chunk %s: %v", chunkHash, err)
}

// Decrypt the chunk if encryption is enabled and not skipped
Expand Down
Loading