Skip to content

Add Space Savings Display to Add Operation#97

Merged
S4tvara merged 1 commit intoS4tvara:mainfrom
MrKeiKun:fix-88-space-save-disp
Oct 5, 2025
Merged

Add Space Savings Display to Add Operation#97
S4tvara merged 1 commit intoS4tvara:mainfrom
MrKeiKun:fix-88-space-save-disp

Conversation

@MrKeiKun
Copy link
Copy Markdown
Contributor

@MrKeiKun MrKeiKun commented Oct 5, 2025

Description
Implements comprehensive space savings tracking and display for the Sietch add operation, providing users with detailed insights into compression efficiency and storage optimization.

Referenced Issue: #88

…ession efficiency per file and in batch summaries

Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 32.20339% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/add.go 32.75% 39 Missing ⚠️
internal/chunk/chunkFile.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@S4tvara
Copy link
Copy Markdown
Owner

S4tvara commented Oct 5, 2025

Hi @MrKeiKun,
Due to the increasing complexity of add.go, I think we should refactor it into separate functions, separating the UI, utility, and core functionality.
I’ll create an issue for this—would you mind picking it up?

Cheers,
Nilay

@MrKeiKun
Copy link
Copy Markdown
Contributor Author

MrKeiKun commented Oct 5, 2025

Sure thing. Start it and all adapt this to it

@S4tvara
Copy link
Copy Markdown
Owner

S4tvara commented Oct 5, 2025

Cool i'll merge this and then create a new issue for that. please make a pr there

@S4tvara S4tvara merged commit 371d4ae into S4tvara:main Oct 5, 2025
27 checks passed
@MrKeiKun
Copy link
Copy Markdown
Contributor Author

MrKeiKun commented Oct 5, 2025

@SubstantialCattle5 ahhhh. you forgot to label it

@S4tvara
Copy link
Copy Markdown
Owner

S4tvara commented Oct 5, 2025

@MrKeiKun Sorry i got very absorbed in merging prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants