Skip to content

Prefer clang over gcc on FreeBSD and OpenBSD - #4887

Open
vassilit wants to merge 1 commit into
SCons:masterfrom
vassilit:bsd_tools
Open

Prefer clang over gcc on FreeBSD and OpenBSD#4887
vassilit wants to merge 1 commit into
SCons:masterfrom
vassilit:bsd_tools

Conversation

@vassilit

Copy link
Copy Markdown

Those platforms ships Clang in their base system.

GCC is somehow supported, but lag behind.

For the record, to test on FreeBSD, I had to:

  • install py312-build and py312-setuptools,
  • install package gmake and change all hard-coded occurences of 'make' to 'gmake' (SCons does not support $MAKE convention).
  • install py312-sphinx-book-theme and py312-pillow (for rst2pdf, required even if the build log shows SKIP_PDF=1).

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

@vassilit

Copy link
Copy Markdown
Author

Related to #4886

@vassilit
vassilit marked this pull request as draft July 29, 2026 11:43
@vassilit

Copy link
Copy Markdown
Author

I think (I have not seen them) that I overlooked side-effects of creating a new platform. There are others platform == 'posix' checks in the code.

@vassilit

Copy link
Copy Markdown
Author

Not too much.

@vassilit
vassilit marked this pull request as ready for review July 29, 2026 12:29
Comment thread SCons/Platform/__init__.py Outdated
Comment thread CHANGES.txt
Those platforms ships Clang in their base system.

Signed-off-by: Vassili Tchersky <vt+git@vbcy.org>
@vassilit

Copy link
Copy Markdown
Author

One error is:

The license for Visual Studio has expired.
Your license for this product is expired and could not be refreshed. Please connect to the internet to continue to use this product.

The other one, I'm not sure. I've looked at TestSCons.run, TestCommon.run, TestCmd.run, etc
But I don't think the modifications I've made have anything to do with the stack size.
Are you sure all the testsuite is idempotent, including the GitHub CI environement ?

@mwichmann

Copy link
Copy Markdown
Collaborator

don't worry about these. the visual studio one is an artifact of the ci image at appveyor. since it frozen, they have to make a new one with the silly license refreshed. we heard they had, but not so in practice. the other is one of a small handful of intermittent fails. not your fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants