Skip to content

Feat #684 Replace Ant Design toast notification - #819

Draft
joao4all wants to merge 7 commits into
developmentfrom
feat/GH684-replace-ant-design-notification-with-devexpress
Draft

Feat #684 Replace Ant Design toast notification#819
joao4all wants to merge 7 commits into
developmentfrom
feat/GH684-replace-ant-design-notification-with-devexpress

Conversation

@joao4all

@joao4all joao4all commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Feats #684 Replace Ant Design toast notification

NOTE: This PR also adds the local server address in development settings so its easier to work in local environment. Also, removed useless "<DxMenuItem Text="Notifications" Position="ItemPosition.End" Visible="false"/>"

NOTE 2: This PR updates dev express version 23.2.15 => 25.1.3

@samatstariongroup samatstariongroup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look at the SonarQube issues

@joao4all joao4all linked an issue Jul 27, 2026 that may be closed by this pull request
8 tasks
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

<ItemGroup>
<PackageReference Include="bunit" Version="2.7.2" />
<PackageReference Include="DevExpress.Blazor" Version="23.2.15" />
<PackageReference Include="DevExpress.Blazor" Version="25.1.3" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert, i am not sure we have the license for this version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version 23.2.15 unfortunately doesn't have toast notifications. Gonna mark this PR as draft, since indeed we would need a license for that upgrade

<PackageReference Include="CDP4ServicesDal-CE" Version="30.1.3" />
<PackageReference Include="CDP4Web-CE" Version="30.1.3" />
<PackageReference Include="DevExpress.Blazor" Version="23.2.15" />
<PackageReference Include="DevExpress.Blazor" Version="25.1.3" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@joao4all
joao4all marked this pull request as draft July 28, 2026 15:32
@joao4all joao4all added the deferred Issue on pause until some other issue is resolved or implemented. label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred Issue on pause until some other issue is resolved or implemented.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Ant Design toast notification

3 participants