Skip to content

add-apollo: add version 0.3.7-hotfix.1 - #392

Open
axxzipoty wants to merge 6 commits into
ScoopInstaller:masterfrom
axxzipoty:add-apollo
Open

add-apollo: add version 0.3.7-hotfix.1#392
axxzipoty wants to merge 6 commits into
ScoopInstaller:masterfrom
axxzipoty:add-apollo

Conversation

@axxzipoty

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Your changes do not pass checks.

apollo-np

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@axxzipoty axxzipoty changed the title add-apollo: add version v0.2.8-alpha.5 add-apollo: add version 0.3.7-hotfix.1 Jul 8, 2025
@SorYoshino SorYoshino self-assigned this Feb 25, 2026
@SorYoshino

Copy link
Copy Markdown
Collaborator

Will using command-line silent installation for Apollo cause any issues?

@SorYoshino SorYoshino added the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Feb 26, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

  • New Features
    • Added a new package manifest for Apollo, making it available for installation and updates.
    • Included setup, shortcut, and configuration details to streamline first-time launch and ongoing use.
    • Added uninstall and cleanup steps to ensure a smoother removal experience.

Walkthrough

Adds a new Scoop package manifest, bucket/apollo-np.json, defining Apollo version 0.3.7-hotfix.1 with download metadata, install/uninstall PowerShell command sequences, packaged binaries, shortcut definition, persisted configuration, and GitHub-based autoupdate checking.

Changes

Apollo Manifest Addition

Layer / File(s) Summary
Apollo package manifest
bucket/apollo-np.json
New manifest defines version/metadata, download URL and hash, pre/post-install and uninstall command sequences with admin checks, bundled binaries, shortcut, persisted config, and autoupdate/version-check configuration.

Related PRs: None identified.

Suggested labels: manifest, new-package

Suggested reviewers: None identified.

🥂 A manifest born, a package anew,
Apollo arrives with scripts to run through,
Install, then persist, then uninstall clean,
Autoupdate watching what GitHub has seen,
Hop, little bucket, your JSON is true!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes the contributing-guide checkbox and omits the required issue reference and summary sections from the template. Add a brief change summary, include Closes/Relates #XXXX, and keep the contributing-guide checkbox.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding Apollo version 0.3.7-hotfix.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
bucket/apollo-np.json (2)

16-19: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Add -ErrorAction SilentlyContinue to the $PLUGINSDIR cleanup.

If $PLUGINSDIR doesn't exist (e.g. differing archive layout on some future release, or a re-run), Remove-Item will throw a terminating error and abort the install with an unclear message instead of continuing.

♻️ Proposed fix
     "pre_install": [
         "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }",
-        "Remove-Item -Path \"$dir\\`$PLUGINSDIR\" -Force -Recurse"
+        "Remove-Item -Path \"$dir\\`$PLUGINSDIR\" -Force -Recurse -ErrorAction SilentlyContinue"
     ],

20-27: 🩺 Stability & Availability | 🔵 Trivial | ⚖️ Poor tradeoff

No exit-code validation on the chained Start-Process install/uninstall steps.

Six post_install steps (driver, firewall, gamepad, service registration/autostart) and five pre_uninstall steps run sequentially via Start-Process -Wait with no check of the process exit code. If any script fails (e.g. sudovda\install.bat fails to register the virtual display driver), Scoop will still report a successful install/uninstall, leaving Apollo partially configured with no visible warning to the user.

Consider capturing $LASTEXITCODE (or -PassThru's ExitCode) after each Start-Process and surfacing a warning/error on failure.

Also applies to: 39-46


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a2a6a27-3f5e-4dd2-a623-d1c13b5a14d3

📥 Commits

Reviewing files that changed from the base of the PR and between cf6c554 and 70b8c03.

📒 Files selected for processing (1)
  • bucket/apollo-np.json

@axxzipoty

axxzipoty commented Jul 6, 2026

Copy link
Copy Markdown
Author

Will using command-line silent installation for Apollo cause any issues?

Just tried it, it works, so just get rid the pwsh script? Although scoop throws some warnings, that the installer adds the version folder to the path.

WARN  Installer added 'C:\Users\user\scoop\apps\apollo-np\0.4.6' to system path. You might want to remove this manually (requires admin permission).
WARN  Installer added 'C:\Users\user\scoop\apps\apollo-np\0.4.6\tools' to system path. You might want to remove this manually (requires admin permission).

Those path entries persist after uninstallation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manifest-fix-needed package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants