add-apollo: add version 0.3.7-hotfix.1 - #392
Conversation
axxzipoty
commented
Jan 23, 2025
- I have read the Contributing Guide.
|
Your changes do not pass checks. apollo-np
|
update version and fix autoupdate
|
Will using command-line silent installation for Apollo cause any issues? |
Summary by CodeRabbit
WalkthroughAdds a new Scoop package manifest, bucket/apollo-np.json, defining Apollo version 0.3.7-hotfix.1 with download metadata, install/uninstall PowerShell command sequences, packaged binaries, shortcut definition, persisted configuration, and GitHub-based autoupdate checking. ChangesApollo Manifest Addition
Related PRs: None identified. Suggested labels: manifest, new-package Suggested reviewers: None identified. 🥂 A manifest born, a package anew, 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
bucket/apollo-np.json (2)
16-19: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winAdd
-ErrorAction SilentlyContinueto the$PLUGINSDIRcleanup.If
$PLUGINSDIRdoesn't exist (e.g. differing archive layout on some future release, or a re-run),Remove-Itemwill throw a terminating error and abort the install with an unclear message instead of continuing.♻️ Proposed fix
"pre_install": [ "if (!(is_admin)) { error \"$app requires admin rights to $cmd\"; break }", - "Remove-Item -Path \"$dir\\`$PLUGINSDIR\" -Force -Recurse" + "Remove-Item -Path \"$dir\\`$PLUGINSDIR\" -Force -Recurse -ErrorAction SilentlyContinue" ],
20-27: 🩺 Stability & Availability | 🔵 Trivial | ⚖️ Poor tradeoffNo exit-code validation on the chained
Start-Processinstall/uninstall steps.Six post_install steps (driver, firewall, gamepad, service registration/autostart) and five pre_uninstall steps run sequentially via
Start-Process -Waitwith no check of the process exit code. If any script fails (e.g.sudovda\install.batfails to register the virtual display driver), Scoop will still report a successful install/uninstall, leaving Apollo partially configured with no visible warning to the user.Consider capturing
$LASTEXITCODE(or-PassThru'sExitCode) after eachStart-Processand surfacing a warning/error on failure.Also applies to: 39-46
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0a2a6a27-3f5e-4dd2-a623-d1c13b5a14d3
📒 Files selected for processing (1)
bucket/apollo-np.json
Just tried it, it works, so just get rid the pwsh script? Although scoop throws some warnings, that the installer adds the version folder to the path. WARN Installer added 'C:\Users\user\scoop\apps\apollo-np\0.4.6' to system path. You might want to remove this manually (requires admin permission).
WARN Installer added 'C:\Users\user\scoop\apps\apollo-np\0.4.6\tools' to system path. You might want to remove this manually (requires admin permission).Those path entries persist after uninstallation. |