Skip to content

docs: add docstrings to avap_blueprint.py (11 functions, 5.5 RTC) - #1650

Closed
Vyacheslav-Tomashevskiy wants to merge 1 commit into
Scottcjn:mainfrom
Vyacheslav-Tomashevskiy:docs-batch18-avap
Closed

docs: add docstrings to avap_blueprint.py (11 functions, 5.5 RTC)#1650
Vyacheslav-Tomashevskiy wants to merge 1 commit into
Scottcjn:mainfrom
Vyacheslav-Tomashevskiy:docs-batch18-avap

Conversation

@Vyacheslav-Tomashevskiy

Copy link
Copy Markdown
Contributor

Adds one-line docstrings to the 11 previously undocumented functions in avap_blueprint.py (Agent Video Attestation Protocol layer: canonical-JSON/hashing/signature-verification crypto helpers, DB init/connection, and all 5 Flask route handlers for anchor/attach/get/health), per the docstring bounty program in docs/CONTRIBUTING_FOR_AGENTS.md (0.5 RTC/function = 5.5 RTC total).

Each docstring was written after reading the actual function body — no guessed/fabricated descriptions. py_compile passes clean.

Wallet: RTCd1554f0f35576faf01d386a6be1c947f560dd0b7

/claim

Bounty docstring program per docs/CONTRIBUTING_FOR_AGENTS.md.
11 functions x 0.5 RTC = 5.5 RTC.
Wallet: RTCd1554f0f35576faf01d386a6be1c947f560dd0b7
@Vyacheslav-Tomashevskiy

Copy link
Copy Markdown
Contributor Author

/claim

@Scottcjn

Scottcjn commented Aug 9, 2026

Copy link
Copy Markdown
Owner

This was queued for merge today and did not go in: it now has merge conflicts with main.

That is partly our doing. A batch of PRs touching the same files was merged in one pass, and the ones later in the queue picked up conflicts from the ones ahead of them. Yours was in the second group.

A rebase onto current main and a force-push is all it needs, and it will merge. If the conflict lands somewhere you would rather not guess at, say so here and I will look at the specific files.

Sorry for the extra round trip.

@Scottcjn

Copy link
Copy Markdown
Owner

Closing this one as superseded — and to be clear up front, not because anything is wrong with the work.

The functions this PR documents all have docstrings on main already, landed by your own #1674. I verified with an AST pass over the file rather than eyeballing it: every function in it now has a docstring, so this diff no longer adds coverage — it would just collide with what is already there.

Since #1674 is merged, you have already been paid for this file. Nothing is owed here and nothing is lost.

Worth saying plainly: this pair existed at all because our review queue was slow, and duplicate submissions are the natural thing to do when a PR sits. That is on us, not on you. Thanks for the docstring sweep — the coverage across these modules is real and it stuck.

@Scottcjn Scottcjn closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants