-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[java][bidi] Handle user prompts during BiDi navigation #17244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krishnamohan-kothapalli
wants to merge
13
commits into
SeleniumHQ:trunk
Choose a base branch
from
krishnamohan-kothapalli:java-bidi-navigation-clean
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
78ce161
[java][bidi] Route navigation commands through BiDi
50a7aac
[java][bidi] Fix BiDi detection and readiness state mapping
krishnamohan-kothapalli b33f9a1
[java][bidi] Fix code formatting
krishnamohan-kothapalli 4fc04b4
[java][bidi] Handle user prompts during BiDi navigation
krishnamohan-kothapalli 8ccc2cb
[java][bidi] Honor pageLoadTimeout in BiDi navigation and fix prompt β¦
krishnamohan-kothapalli 8d5e675
Merge branch 'trunk' into java-bidi-navigation-clean
krishnamohan-kothapalli cfed07f
[java][bidi] Fix per-navigation prompt listener scope to prevent alerβ¦
krishnamohan-kothapalli 7d99f1f
Merge branch 'trunk' into java-bidi-navigation-clean
krishnamohan-kothapalli 0f63055
[java][bidi] Throw UnhandledAlertException for *_AND_NOTIFY prompt poβ¦
krishnamohan-kothapalli 30d2ffb
[java][bidi] Fix biDiPageLoadTimeout synchronization
krishnamohan-kothapalli c1aff62
[java][bidi] Fix missing Json/JsonInput imports and getPageLoadDuratiβ¦
krishnamohan-kothapalli b42bd10
[java][bidi] Subscribe once per session for prompt handling during Biβ¦
krishnamohan-kothapalli aa400a8
[java][bidi] Reset prompt listener flag on subscribe failure to allowβ¦
krishnamohan-kothapalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.