Skip to content

[py][build] Update bazel rules_python#17403

Closed
cgoldberg wants to merge 6 commits into
SeleniumHQ:trunkfrom
cgoldberg:py-bump-rules-python
Closed

[py][build] Update bazel rules_python#17403
cgoldberg wants to merge 6 commits into
SeleniumHQ:trunkfrom
cgoldberg:py-bump-rules-python

Conversation

@cgoldberg
Copy link
Copy Markdown
Member

@cgoldberg cgoldberg commented Apr 28, 2026

💥 What does this PR do?

Bump bazel rules_python to 2.0.1 (no toolchain version upgrades in this release)

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • Build

@cgoldberg cgoldberg self-assigned this Apr 28, 2026
@cgoldberg cgoldberg added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Apr 28, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Apr 28, 2026

Review Summary by Qodo

(Agentic_describe updated until commit 553f0a3)

Bump bazel rules_python to 2.0.1

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Bump bazel rules_python from 1.9.0 to 2.0.1
• Updates MODULE.bazel dependency configuration
Diagram
flowchart LR
  A["rules_python 1.9.0"] -- "version upgrade" --> B["rules_python 2.0.1"]
  B -- "MODULE.bazel" --> C["Updated dependency"]
Loading

Grey Divider

File Changes

1. MODULE.bazel Dependencies +1/-1

Upgrade rules_python dependency version

• Updated rules_python bazel dependency from version 1.9.0 to 2.0.1
• No other dependencies modified

MODULE.bazel


Grey Divider

Qodo Logo

@cgoldberg
Copy link
Copy Markdown
Member Author

ugh... upgrading to rules_python 2.0.0 breaks the build.

I documented this at: #17404
This needs to be fixed before we can merge this.

@cgoldberg cgoldberg marked this pull request as draft April 28, 2026 22:30
@cgoldberg cgoldberg marked this pull request as ready for review May 15, 2026 14:15
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit 553f0a3

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit 5c5a924

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 15, 2026

Persistent review updated to latest commit d044864

@SeleniumHQ SeleniumHQ deleted a comment from qodo-code-review Bot May 15, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented May 18, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Advisory comments

1. Version intent mismatch 🐞 Bug ⚙ Maintainability
Description
MODULE.bazel pins rules_python to 2.0.1, but the PR description states this bump is to 2.0.0; this
inconsistency can mislead reviewers and complicate future dependency-bisects/audits.
Code

MODULE.bazel[40]

+bazel_dep(name = "rules_python", version = "2.0.1")
Evidence
The repo pins rules_python to 2.0.1 in MODULE.bazel, which conflicts with the PR description’s
stated target version (2.0.0).

MODULE.bazel[40-40]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The PR description says the bump is to `rules_python` **2.0.0**, but `MODULE.bazel` pins **2.0.1**. This mismatch is a documentation/intent inconsistency that can cause confusion later.

### Issue Context
`MODULE.bazel` is the source of truth for the module version actually used by Bazel.

### Fix Focus Areas
- MODULE.bazel[40-40]

### Expected fix
Either:
1) Update the PR title/description to say `2.0.1` (if that’s intended), **or**
2) Change `MODULE.bazel` to `version = "2.0.0"` (if 2.0.0 is the intended target).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Previous review results

Review updated until commit 79b8055

Results up to commit 553f0a3


🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)


Advisory comments
1. Version intent mismatch 🐞 Bug ⚙ Maintainability
Description
MODULE.bazel pins rules_python to 2.0.1, but the PR description states this bump is to 2.0.0; this
inconsistency can mislead reviewers and complicate future dependency-bisects/audits.
Code

MODULE.bazel[40]

+bazel_dep(name = "rules_python", version = "2.0.1")
Evidence
The repo pins rules_python to 2.0.1 in MODULE.bazel, which conflicts with the PR description’s
stated target version (2.0.0).

MODULE.bazel[40-40]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The PR description says the bump is to `rules_python` **2.0.0**, but `MODULE.bazel` pins **2.0.1**. This mismatch is a documentation/intent inconsistency that can cause confusion later.

### Issue Context
`MODULE.bazel` is the source of truth for the module version actually used by Bazel.

### Fix Focus Areas
- MODULE.bazel[40-40]

### Expected fix
Either:
1) Update the PR title/description to say `2.0.1` (if that’s intended), **or**
2) Change `MODULE.bazel` to `version = "2.0.0"` (if 2.0.0 is the intended target).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Qodo Logo

@cgoldberg
Copy link
Copy Markdown
Member Author

superseded by #17502

@cgoldberg cgoldberg closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant