-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps-dev): bump the tooling group across 1 directory with 4 updates #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
b639d2b
chore(deps-dev): bump the tooling group across 1 directory with 4 upd…
dependabot[bot] 4008478
fix: migrate to eslint flat config + pin eslint ^9 + disable new reac…
satyakwok f5bbb02
fix: add app-local globals.d.ts for CSS side-effect imports
satyakwok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,30 @@ | ||
| import { dirname } from "path"; | ||
| import { fileURLToPath } from "url"; | ||
| import { FlatCompat } from "@eslint/eslintrc"; | ||
| import { defineConfig, globalIgnores } from "eslint/config"; | ||
| import nextVitals from "eslint-config-next/core-web-vitals"; | ||
| import nextTs from "eslint-config-next/typescript"; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| }); | ||
|
|
||
| const eslintConfig = [ | ||
| ...compat.extends("next/core-web-vitals", "next/typescript"), | ||
| const eslintConfig = defineConfig([ | ||
| ...nextVitals, | ||
| ...nextTs, | ||
| globalIgnores([ | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ]), | ||
| { | ||
| ignores: [ | ||
| "node_modules/**", | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ], | ||
| rules: { | ||
| // TODO: re-enable once the React 19 / react-compiler refactor lands. | ||
| // The eslint-plugin-react-hooks v6 (pulled in via eslint-config-next 16) | ||
| // ships new compiler-aware rules that flag ~30 violations across the | ||
| // monorepo — every one is a real refactor, not a quick fix. | ||
| "react-hooks/preserve-manual-memoization": "off", | ||
| "react-hooks/purity": "off", | ||
| "react-hooks/refs": "off", | ||
| "react-hooks/set-state-in-effect": "off", | ||
| "react-hooks/static-components": "off", | ||
| "react-hooks/use-memo": "off", | ||
| }, | ||
| }, | ||
| ]; | ||
| ]); | ||
|
|
||
| export default eslintConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
|
|
||
| // CSS side-effect imports (e.g. `import "./globals.css"`) | ||
| // Typically declared by the auto-generated next-env.d.ts, but that | ||
| // file is gitignored + only emitted after `next build`. CI runs | ||
| // `pnpm typecheck` before `next build`, so we mirror those refs | ||
| // here to keep TS 6 happy. | ||
| declare module "*.css"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,29 @@ | ||
| import { dirname } from "path"; | ||
| import { fileURLToPath } from "url"; | ||
| import { FlatCompat } from "@eslint/eslintrc"; | ||
| import { defineConfig, globalIgnores } from "eslint/config"; | ||
| import nextVitals from "eslint-config-next/core-web-vitals"; | ||
| import nextTs from "eslint-config-next/typescript"; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| }); | ||
|
|
||
| const eslintConfig = [ | ||
| ...compat.extends("next/core-web-vitals", "next/typescript"), | ||
| { | ||
| ignores: [ | ||
| "node_modules/**", | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ], | ||
| }, | ||
| const eslintConfig = defineConfig([ | ||
| ...nextVitals, | ||
| ...nextTs, | ||
| globalIgnores([ | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ]), | ||
| { | ||
| rules: { | ||
| // External token images are dynamic URLs — skip next/image optimization | ||
| "@next/next/no-img-element": "off", | ||
| // TODO: re-enable once the React 19 / react-compiler refactor lands. | ||
| "react-hooks/preserve-manual-memoization": "off", | ||
| "react-hooks/purity": "off", | ||
| "react-hooks/refs": "off", | ||
| "react-hooks/set-state-in-effect": "off", | ||
| "react-hooks/static-components": "off", | ||
| "react-hooks/use-memo": "off", | ||
| }, | ||
| }, | ||
| ]; | ||
| ]); | ||
|
|
||
| export default eslintConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
|
|
||
| // CSS side-effect imports (e.g. `import "./globals.css"`) | ||
| // Typically declared by the auto-generated next-env.d.ts, but that | ||
| // file is gitignored + only emitted after `next build`. CI runs | ||
| // `pnpm typecheck` before `next build`, so we mirror those refs | ||
| // here to keep TS 6 happy. | ||
| declare module "*.css"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,30 @@ | ||
| import { dirname } from "path"; | ||
| import { fileURLToPath } from "url"; | ||
| import { FlatCompat } from "@eslint/eslintrc"; | ||
| import { defineConfig, globalIgnores } from "eslint/config"; | ||
| import nextVitals from "eslint-config-next/core-web-vitals"; | ||
| import nextTs from "eslint-config-next/typescript"; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| }); | ||
|
|
||
| const eslintConfig = [ | ||
| ...compat.extends("next/core-web-vitals", "next/typescript"), | ||
| const eslintConfig = defineConfig([ | ||
| ...nextVitals, | ||
| ...nextTs, | ||
| globalIgnores([ | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ]), | ||
| { | ||
| ignores: [ | ||
| "node_modules/**", | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ], | ||
| rules: { | ||
| // TODO: re-enable once the React 19 / react-compiler refactor lands. | ||
| // The eslint-plugin-react-hooks v6 (pulled in via eslint-config-next 16) | ||
| // ships new compiler-aware rules that flag ~30 violations across the | ||
| // monorepo — every one is a real refactor, not a quick fix. | ||
| "react-hooks/preserve-manual-memoization": "off", | ||
| "react-hooks/purity": "off", | ||
| "react-hooks/refs": "off", | ||
| "react-hooks/set-state-in-effect": "off", | ||
| "react-hooks/static-components": "off", | ||
| "react-hooks/use-memo": "off", | ||
| }, | ||
| }, | ||
| ]; | ||
| ]); | ||
|
|
||
| export default eslintConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
|
|
||
| // CSS side-effect imports (e.g. `import "./globals.css"`) | ||
| // Typically declared by the auto-generated next-env.d.ts, but that | ||
| // file is gitignored + only emitted after `next build`. CI runs | ||
| // `pnpm typecheck` before `next build`, so we mirror those refs | ||
| // here to keep TS 6 happy. | ||
| declare module "*.css"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Sentriscloud/frontend
Length of output: 539
🌐 Web query:
Iseslint-config-next@16.2.6officially compatible withnext@15.5.xandeslint@9.x?💡 Result:
No, eslint-config-next@16.2.6 is not officially compatible with next@15.5.x. The package versioning aligns with Next.js major versions: eslint-config-next 15.x is for Next.js 15.x [1][2][3], while 16.x (including 16.2.6, published May 7, 2026 [4][5]) is for Next.js 16 [6][7][8]. Next.js 16 introduces breaking changes to ESLint support, defaulting to flat config and removing
next lint[6][7]. Using 16.x with Next.js 15 may cause peer dependency conflicts, as seen when third-party configs expect@next/eslint-plugin-next^15.0.0 but find v16 [8]. For ESLint 9.x, Next.js 15 supports it with specific flat config setups [9][10][11], but eslint-config-next@16.2.6's flat config changes [6] are optimized for Next.js 16. Official docs recommend matching eslint-config-next version to Next.js version [7][1].Citations:
eslint-config-nextto match Next.js 15 nrwl/nx#30258🌐 Web query:
Is TypeScript 6.x officially supported by Next.js 15.5.x?💡 Result:
Yes—Next.js 15.5.x is compatible with (and effectively supported for) TypeScript 6.x. Next.js’s official docs specify a minimum TypeScript version of 5.1.0 for TypeScript support, not a maximum version [1]. That means TypeScript 6.x is within the supported range as far as Next.js’s published minimum requirement goes. Additionally, Next.js’s own development history includes a merged PR titled “Bump TypeScript to 6.0”, indicating the Next.js codebase (and associated tooling like type checking) was updated to work with TypeScript 6.0 on their side [2]. Conclusion: there is no Next.js 15.5.x “not supported” restriction against TypeScript 6.x in the official minimum-version guidance [1], and Next.js maintainers have explicitly bumped/validated TypeScript 6.0 in their project [2].
Citations:
Downgrade
eslint-config-nextto version 15.x for compatibility with Next.js 15.5.18.Line 39 declares
eslint-config-next@16.2.6, but this is incompatible withnext@15.5.18. The eslint-config-next package versions align with Next.js major versions: 15.x for Next.js 15, and 16.x for Next.js 16. Using 16.2.6 with Next.js 15.5.18 introduces peer dependency conflicts due to Next.js 16's breaking changes to ESLint configuration. Change toeslint-config-next@15.xto match the deployed Next.js version.TypeScript 6.x (line 41) and
@types/node@^25(line 35) are compatible with Next.js 15.5.18 and Node 20.🤖 Prompt for AI Agents