Skip to content

chore: scrub internal-file ref from proto comment#63

Merged
satyakwok merged 1 commit into
mainfrom
chore/scrub-proto-comment
May 13, 2026
Merged

chore: scrub internal-file ref from proto comment#63
satyakwok merged 1 commit into
mainfrom
chore/scrub-proto-comment

Conversation

@satyakwok
Copy link
Copy Markdown
Member

@satyakwok satyakwok commented May 13, 2026

packages/chain/proto/sentrix.proto carried the same leaky comment that was already scrubbed upstream in sentrix-labs/sentrix and in sdk-ts/src/grpc-web/*. This brings it in line.

Summary by CodeRabbit

  • Chores
    • Updated internal documentation reference in protocol definition file. No functional changes or user-facing impact.

Review Change Stack

Matches the upstream sentrix-labs/sentrix proto and the sdk-ts grpc-web
generated headers, both already neutralized. 'founder-private/audits/...'
-> 'internal Sentrix Labs gRPC service-proto draft (2026-05-05)'.
@satyakwok satyakwok enabled auto-merge (squash) May 13, 2026 08:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5f4c060c-2369-4e9f-ae50-52082bebe996

📥 Commits

Reviewing files that changed from the base of the PR and between 3248229 and 43174ff.

📒 Files selected for processing (1)
  • packages/chain/proto/sentrix.proto

📝 Walkthrough

Walkthrough

This PR updates a single comment line in packages/chain/proto/sentrix.proto. The top-of-file comment is replaced with a new inline reference to the internal gRPC service-proto draft. No protobuf message definitions, service declarations, or field numbers are altered. This is a documentation-only change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains what was changed and why, but is missing the required Template sections (Test plan and Related links), making it incomplete against the repository template. Add the Test plan section with a checklist of test cases and the Related section with relevant issue/PR links or documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing an internal file reference from a proto comment, which matches the changeset and commit intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/scrub-proto-comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@satyakwok satyakwok merged commit 447a311 into main May 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant