-
Notifications
You must be signed in to change notification settings - Fork 0
build(deps): bump share_plus from 10.1.4 to 13.1.0 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/pub/share_plus-13.1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: Sentriscloud/solux
Length of output: 874
🌐 Web query:
share_plus v13 migration guide breaking changes Share.share() API compatibility💡 Result:
share_plus v13 migration / breaking changes relevant to Share.share compatibility 1) What changed (API migration) - The plugin’s old static API methods
Share.share(),Share.shareUri(), andShare.shareXFiles()are deprecated in favor ofSharePlus.instance.share(params)[1][2]. - The migration guidance is: wrap your old arguments in aShareParams(...)object, then callSharePlus.instance.share(...)instead of the staticShare.*methods [1][2]. 2) Compatibility details for Share.share usage -Share.share()(and the other static methods) still exist but are marked deprecated, meaning they remain usable for now but you should migrate to avoid deprecation and eventual removal [1][2][3]. - The new approach uses a single instance (SharePlus.instance) plusShareParams, rather than multiple static convenience methods [1][2]. 3) Concrete migration example Old: -Share.share("Shared text");-Share.shareUri("http://example.com");-Share.shareXFiles(files);[1] New: -SharePlus.instance.share(ShareParams(text: "Shared text"));-SharePlus.instance.share(ShareParams(uri: "http://example.com"));-SharePlus.instance.share(ShareParams(files: files));[1] 4) “Breaking changes” in share_plus v13 itself (non-API) - The published changelog forshare_plusversion 13.0.0 explicitly warns that it contains breaking changes, but those breaking changes listed there are dependency/requirement related (e.g., win32 dependency bump changing requirements such as minimum Flutter/Dart versions and iOS/macOS minima) rather than theShare.share()deprecation/migration itself [4][5]. If you share your exact current code (the specificShare.share*call sites and whichShare.*parameters you use, plus whether you pass title/subject/sharePositionOrigin), I can map each call to the equivalentShareParamsusage.Citations:
The old
Share.share()API is deprecated in v13 but still functional—update when convenient.The
Share.share()method used inlib/screens/receive/receive_screen.dart:164is deprecated in share_plus v13 but remains usable. While your code will continue to work, migrate to the new API pattern to future-proof against eventual removal:Share.share('My SRX address: $address')SharePlus.instance.share(ShareParams(text: 'My SRX address: $address'))Update the import and method call at the location above to use
SharePlusandShareParamsfor consistency with v13 best practices.🤖 Prompt for AI Agents