Skip to content

Praw update - #1012

Open
EkriirkE wants to merge 6 commits into
Serene-Arc:developmentfrom
EkriirkE:praw-update
Open

Praw update#1012
EkriirkE wants to merge 6 commits into
Serene-Arc:developmentfrom
EkriirkE:praw-update

Conversation

@EkriirkE

@EkriirkE EkriirkE commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

The oauth token manager is obsoleted, and removed.. This restores compatibility with the most recent praw library

@Serene-Arc

Copy link
Copy Markdown
Owner

This removes all of the code but doesn't add any. If. it's going to be fixed, we'd have to implement the new authentication, no? An unauthenticated instance would be extremely slow and throttled.

@EkriirkE

EkriirkE commented Apr 12, 2026

Copy link
Copy Markdown
Contributor Author

Per the notes on the last working praw BaseTokenManager https://github.com/praw-dev/praw/blob/v7.7.1/praw/util/token_manager.py the functionality was removed, and the code there just looks like an empty framework without function anyway. BDFR only fiddled with passing the token on 1 callback.
So I see it now. It seems praw replaced this with an explicit refresh_token vs a token_manager class with callbacks.
Fixed as well.

--authenticate tested OK on my end with both initializing the app token, and utilizing it in subsequent calls

@sirmaestro

Copy link
Copy Markdown

Without this change I couldn't get bdfr to work at all, with or without --authenticate flag. So I vote for adding this in.

@EkriirkE

EkriirkE commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

The remaining test errors are beyond the scope of this PR (even though I did fix the iana logo download link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants