feat: explore dynamic dispatch for checkout delegate#125
Draft
kieran-osgood-shopify wants to merge 1 commit into
Conversation
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 14, 2026
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegate
branch
from
204573a to
2e3e7a2
Compare
11 tasks
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featexploredynamicdispatchforcheckoutdelegate
branch
from
2e3e7a2 to
ac67cdd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-14-featremoveaddeventlistenerapi
branch
from
866347c to
86cefb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The JS handler positional argument approach wasn't very scalable when we add in the dynamic dispatch of the protocol messages to come in a follow up
Exploring a dynamic dispatch approach for the native sdk methods, need to consider if recover from error can be handled via this approach now its sync
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.