[Swift] Remove ec_color_scheme query param - #96
Merged
Conversation
toneymathews
approved these changes
May 13, 2026
toneymathews
left a comment
toneymathews
left a comment
Contributor
There was a problem hiding this comment.
leaving one question, lgtm otherwise
Juanita-Dash
force-pushed
the
swift/remove-ec-color-scheme
branch
from
May 13, 2026 19:06
bf9bf8a to
782815b
Compare
markmur
reviewed
May 14, 2026
Juanita-Dash
force-pushed
the
swift/remove-ec-color-scheme
branch
from
May 14, 2026 13:48
782815b to
4778478
Compare
Juanita-Dash
changed the title
kyle-schellen
approved these changes
May 15, 2026
kiftio
approved these changes
May 15, 2026
Part of https://github.com/shop/issues-checkout-kit/issues/906. The Checkout Kits will no longer thread color scheme through ECP. This PR strips ec_color_scheme emission from the Swift kit: - CheckoutProtocol.url(for:): drop the colorScheme parameter and the ec_color_scheme queryItem; ec_version still emitted - CheckoutViewController.init and ShopifyCheckoutKit.preload/present: drop the colorScheme argument at the 4 call sites CheckoutProtocol.url(for:colorScheme:) is public but PR #65 has not yet been released (no 3.8.0 tag), so removing the parameter outright is safe. Android equivalent landed in #95. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Juanita-Dash
force-pushed
the
swift/remove-ec-color-scheme
branch
from
May 15, 2026 13:33
4778478 to
3c95eeb
Compare
11 tasks
kieran-osgood-shopify
added a commit
that referenced
this pull request
May 21, 2026
### What changes are you making? Android currently has an API dump and API check command that helps us snapshot and determine any public API drift. this change brings the same dump and check snapshotting ability to React Native and Swift. and wires them in as blocking CI steps when we detect a public change in order to get the CIO passing, you'll need to regenerate the snapshot so that there's no drift detected on CI. <img width="1325" height="1333" alt="image" src="https://github.com/user-attachments/assets/9570c62d-c5d7-448e-a684-92db16c77a9f" /> ### How to test Example failing CI run for a branch that hadn't rebased to include mains changes of [removing ec_color_scheme](#96) https://github.com/Shopify/checkout-kit/actions/runs/25923211711/job/76197466792?pr=130 --- ### Before you merge > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`) --- <details> <summary>Releasing a new Swift version?</summary> - [ ] I have bumped the version in `ShopifyCheckoutKit.podspec` - [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift` - [ ] I have updated `platforms/swift/CHANGELOG.md` - [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only) </details> <details> <summary>Releasing a new Android version?</summary> - [ ] I have bumped the `versionName` in `platforms/android/lib/build.gradle` - [ ] I have updated `platforms/android/CHANGELOG.md` - [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md` </details> > [!TIP] > See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/shop/issues-checkout-kit/issues/906.
Changes: