Skip to content

[Security] Redact cookies from debug logs #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
May 20, 2026
+4 −2
Merged

[Security] Redact cookies from debug logs #7531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cli-kit/src/private/node/api/headers.test.ts
View file
Open in desktop
Comment thread
gonzaloriestra marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('common API methods', () => {
},
)

test('sanitizedHeadersOutput removes the headers that include the token', () => {
test('sanitizedHeadersOutput removes sensitive headers', () => {
// Given
const headers = {
'User-Agent': 'useragent',
Expand All @@ -85,6 +85,8 @@ describe('common API methods', () => {
authorization: 'token',
'Content-Type': 'application/json',
'X-Shopify-Access-Token': 'token',
Cookie: 'session=123',
'Set-Cookie': 'session=456',
}

// When
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-kit/src/private/node/api/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class GraphQLClientError extends RequestClientError {
*/
export function sanitizedHeadersOutput(headers: Record<string, string>): string {
const sanitized: Record<string, string> = {}
const keywords = ['token', 'authorization', 'subject_token']
const keywords = ['token', 'authorization', 'subject_token', 'cookie']
Object.keys(headers).forEach((header) => {
if (keywords.find((keyword) => header.toLocaleLowerCase().includes(keyword)) === undefined) {
sanitized[header] = headers[header]!
Expand Down
Loading