Fix Windows auto-upgrade for local CLI installs#7553
Merged
2 commits merged intoMay 15, 2026
Merged
Conversation
`currentProcessIsGlobal()` decides between global and local installs by comparing the project root against `process.argv[1]`. The project root flows through `getProjectDir` -> `findPathUpSync` -> `normalizePath` (pathe), which always returns forward slashes on every platform. `process.argv[1]` is OS-native, so on Windows it arrives backslash-separated and the raw `startsWith` comparison ends up as: binDir: C:\\Users\\me\\proj\\node_modules\\@Shopify\\cli\\bin\\run.js projectDir: C:/Users/me/proj binDir.startsWith(projectDir) => false The local install was misclassified as global, so the postrun hook ran `npm install -g @shopify/cli@latest` after every command on Windows even when @shopify/cli was declared as a project dependency. Switches the comparison to `isSubpath` (pathe.relative under the hood) which tolerates either separator, and bails early if argv[1] is empty so we don't accidentally classify it as 'in any directory'. Adds a regression test that constructs the exact Windows shape (forward- slash projectDir vs. backslash argv[1]) — the existing POSIX-shaped tests happened to agree on slashes when CI runs on Linux, so they didn't catch this. Reported by Nick Wesselman; root cause analysis by River.
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @alfonso-noriega! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260515092709Caution After installing, validate the version by running |
dd4e5c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Reported by Nick Wesselman in #shopify-cli: on Windows, running
shopify app dev(or any command) in a project where@shopify/cliis a project-local dependency still triggers the global auto-upgrade flow — it runsnpm install -g @shopify/cli@latestafter every command. Confirmed working correctly on macOS + Linux.Root-cause analysis by River:
currentProcessIsGlobal()inpackages/cli-kit/src/public/node/is-global.tsdecides between global and local installs by comparing the project root againstprocess.argv[1]:projectDirflows throughgetProjectDir→findPathUpSync→normalizePath(pathe). Pathe always normalizes to forward slashes on every platform →C:/Users/me/proj.process.argv[1]arrives in OS-native form. On Windows that's backslash-separated →C:\Users\me\proj\node_modules\@shopify\cli\bin\run.js.binDir.startsWith(projectDir)→false.runCLIUpgrade()takes the global branch →npm install -g @shopify/cli@latest.macOS + Linux are unaffected because their native
argv[1]already uses/.WHAT is this pull request doing?
Two-line behavioural fix + a regression test:
packages/cli-kit/src/public/node/is-global.ts— replace the rawstartsWithwithisSubpath(projectDir, binDir), which goes throughpathe.relativeand tolerates either separator. Also bail early ifargv[1]is empty so we don't accidentally classify "no script path" as "inside any directory".packages/cli-kit/src/public/node/is-global.test.ts— new test that constructs the exact Windows shape (projectDir = 'C:/Users/me/project',argv[1] = 'C:\\Users\\me\\project\\…'). The existing POSIX-shaped tests happened to agree on slashes when CI runs on Linux, which is why this slipped through..changeset/fix-windows-autoupgrade-local-dep.md— patch on@shopify/cli-kit.startsWith)isSubpath)How to test your changes?
End-to-end, on Windows, in a project that has
@shopify/clideclared inpackage.json:Before: a global
npm install -g @shopify/cli@latestruns after the command.After: no global install runs — the project-local code path is taken (which, for now, also short-circuits per the auto-upgrade-skip-local change).
Checklist
@shopify/cli-kitCredit: bug reported by @nickwesselman; root-cause + suggested fix by River.