Add command to stop motor for S2 RPLidar#140
Open
MaximBolduc wants to merge 1 commit intoSlamtec:masterfrom
Open
Add command to stop motor for S2 RPLidar#140MaximBolduc wants to merge 1 commit intoSlamtec:masterfrom
MaximBolduc wants to merge 1 commit intoSlamtec:masterfrom
Conversation
Same changes that was made int he ROS2 version was added to this ROS1 commit. Without it, we had a problem where RPLidar A series would stop like they should but S series would start automatically then never stop when the service was called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes that was made int he ROS2 version was added to this ROS1 commit.
Without it, we had a problem where RPLidar A series would stop like they should but S series would start automatically then never stop when the service was called.
fix #83