Fix angle_min and angle_max of the LaserScan data#157
Open
mferuscomelo wants to merge 1 commit intoSlamtec:ros2from
Open
Fix angle_min and angle_max of the LaserScan data#157mferuscomelo wants to merge 1 commit intoSlamtec:ros2from
mferuscomelo wants to merge 1 commit intoSlamtec:ros2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LaserScan data from my RPLiDAR C1M1 had an angular range of -180 to 180 deg, even though scan->ranges[0] returned the distance at 0 degrees. To fix this, the angular range should be 0 to 360 deg, as fixed between lines 254 and 264. The rest is just formatting.