fix: move nullptr_t definition to sdk_common.h#45
Open
zhangyx1998 wants to merge 1 commit intoSlamtec:mainfrom
Open
fix: move nullptr_t definition to sdk_common.h#45zhangyx1998 wants to merge 1 commit intoSlamtec:mainfrom
zhangyx1998 wants to merge 1 commit intoSlamtec:mainfrom
Conversation
…h so sl_async_transceiver.cpp can also access it
nyne-nyne
added a commit
to Perceptyne-Technologies/sllidar_ros2
that referenced
this pull request
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move definition of
nullptr_ttosdk_common.h(it was previously located insl_lidar_driver.cpp) to sdkcommon.h so sl_async_transceiver.cpp can also access it.Before applying this change, compile will end with error because
nullptr_tis not defined at sdk/src/sl_async_transceiver.cpp:204.This change has been tested with gcc version 13.2.0 (Ubuntu 13.2.0-23ubuntu4)