adding possibility for node options & parameter for changing scan topic#50
Open
chaselolley wants to merge 1 commit intoSlamtec:mainfrom
Open
adding possibility for node options & parameter for changing scan topic#50chaselolley wants to merge 1 commit intoSlamtec:mainfrom
chaselolley wants to merge 1 commit intoSlamtec:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters did not have a way to be changed via a launch or config file, so they needed to be hard-coded in sllidar_node.cpp. This adds the capability to have those parameters be found from launch or config files without having to hardcode values in the parameter declarations in the cpp file. Also added a specific parameter using node options for changing the topic that is referred to for laser scans.