Matter Ikea Scroll: Aggregate multiple responses into one event, remove InitialPress handling during scroll#3014
Merged
Conversation
|
Channel deleted. |
Test Results 73 files 515 suites 0s ⏱️ Results for commit 1799207. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1799207 |
hcarter-775
force-pushed
the
add/multi-response-block-support
branch
from
June 5, 2026 16:21
336c8e1 to
0ca61eb
Compare
hcarter-775
force-pushed
the
add/multi-response-block-support
branch
from
June 5, 2026 17:44
0ca61eb to
1fa21e3
Compare
hcarter-775
requested review from
ctowns,
gharveymn,
nickolas-deboom and
tpmanley
June 5, 2026 17:46
tpmanley
reviewed
Jun 5, 2026
tpmanley
reviewed
Jun 15, 2026
| local presses_in_current_chain = 0 | ||
| for _, ib in ipairs(info_blocks) do | ||
| if ib.info_block.event_id == clusters.Switch.events.MultiPressOngoing.ID then | ||
| presses_in_current_chain = presses_in_current_chain + (ib.info_block.data.elements and ib.info_block.data.elements.current_number_of_presses_counted.value or 0) |
Contributor
There was a problem hiding this comment.
If the message contains multiple MultiPressOngoing events I think we want to take the current_number_of_presses_counted from the last one and not add the value reported in each one. For example, say we receive a message that has MultiPressOngoing events with current_number_of_presses_counted values of 3, 6 and 12. We want the result to be 12, not 3 + 6 + 12.
Contributor
Author
There was a problem hiding this comment.
ah, yeah that's very true. Will make that update!
hcarter-775
changed the title
hcarter-775
changed the title
tpmanley
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add aggregation logic to ensure that only the last info block is handled when multiple responses come in to the driver at once, leaving all single-response chunks unaltered. This should aggregate all un-handled steps into before sending out the single event.
Remove any mapping for InitialPress to a rotateAmount event.
Summary of Completed Tests
Tested on various numbers of devices to ensure performant behavior across these varying cases.