Fix teleop re-engagement by resetting robot pose anchor on move start - #1
Open
MNikoliCC wants to merge 1 commit into
Open
Fix teleop re-engagement by resetting robot pose anchor on move start#1MNikoliCC wants to merge 1 commit into
MNikoliCC wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes move re-engagement behavior in
lerobot_teleoperator_teleop.The teleoperator now treats each new
movepress as a fresh teleop session and computespose_from_initialrelative to the pose at the start of that session. This prevents stale motion from being reused whenmoveis released and pressed again.What changed
In
lerobot_teleoperator_teleop/teleop.py:movesessionmoveis releasedpose_from_initialas a delta from the current session start poseWhy
Before this change, re-pressing
moveafter releasing it could reuse previously accumulated motion instead of starting from zero for the new hold session.With this change:
move: motion is tracked normallymove: session state is clearedmoveagain: delta starts from zero for the new sessionScope
This PR only updates
lerobot_teleoperator_teleop.Robot-specific/custom interfaces that consume
pose_from_initialmay still need matching adjustments on their side depending on how they anchor and apply the pose delta.Example: SpesRobotics/lerobot-robot-xarm#1 (comment)