Skip to content

Various improvements#438

Open
7heo wants to merge 3 commits into
SrainApp:masterfrom
7heo:master
Open

Various improvements#438
7heo wants to merge 3 commits into
SrainApp:masterfrom
7heo:master

Conversation

@7heo
Copy link
Copy Markdown

@7heo 7heo commented Mar 27, 2026

I grouped the contributions in one PR, because they are trivial:

  • Add KP_Enter as a "send" key in addition to "Return"
  • Improve shell scripts
  • Remove bash dependency on Makefile

@SilverRainZ
Copy link
Copy Markdown
Member

Hello, thanks for you contribution, please split the changes about the source code and the build script into different PRs.

Comment thread script/macos-pkgconfig-path.sh
Comment thread script/rename-g-type.sh
Comment thread Makefile
else
$(MESON) setup --prefix=$(PREFIX) --buildtype=debug -Dapp_indicator=false $@; \
endif
endif
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two endif?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two if, two endif.

@7heo
Copy link
Copy Markdown
Author

7heo commented Apr 1, 2026

Hello, thanks for you contribution, please split the changes about the source code and the build script into different PRs.

Ok. Will eventually do, but not today, ENOTIME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants