[BugFix] Avoid redundant latestSnapshot() call in PaimonMetadata#getTableVersionRange - #72892
Conversation
…#getTableVersionRange
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Youngwb Could you take a moment to review this PR when you are free? |
|
@miomiocat this PR requires two approvals. If you have a minute, could you help introduce another committer to review it? Thank you so much! |
|
@stdpain this PR requires two approvals. If you have a minute, could you help introduce another committer to review it? Thank you so much! |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@Mergifyio backport branch-3.5 |
|
@Mergifyio backport branch-4.0 |
|
@Mergifyio backport branch-4.1 |
✅ Backports have been createdDetails
Cherry-pick of 0340ccd has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
✅ Backports have been createdDetails
Cherry-pick of 0340ccd has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
✅ Backports have been createdDetails
|
|
change PR type to bugfix |
…ableVersionRange (backport #72892) (backport #73121) (#73430) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: haoyuhua <haoyuhua007@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kevincai <771299+kevincai@users.noreply.github.com>
What I'm doing:
Fixes #72891
Duplicate
latestSnapshot()in the same methodIn
PaimonMetadata.getRemoteFileInfos()(source):latestSnapshot()internally callsSnapshotManager.latestSnapshot()→latestSnapshotFromFileSystem()→ reads the S3 LATEST hint file every time. The result is never stored in a local variable.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: