[Enhancement] Support partial pushdown for AND compound predicates in Iceberg connector (backport #70293) - #73085
Merged
Conversation
satanson
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When converting StarRocks SQL predicates to Iceberg expressions in
ScalarOperatorToIcebergExpr.visitCompoundPredicate(), if anAND(left, right)compound predicate has only one convertible side, the entire predicate is discarded. This is unnecessarily conservative -- for AND semantics, pushing down the convertible side alone is still a valid filter (it may include extra rows but never excludes valid ones). This missed optimization prevents partition pruning and data skipping in cases where at least one side of an AND predicate is pushable.What I'm doing:
Added
insideNottracking toIcebergContext: Added aboolean insideNotfield with awithInsideNot()factory method. When visiting the child of aNOTexpression, the context is marked as inside-NOT to prevent unsafe partial pushdown.Implemented AND partial pushdown in
visitCompoundPredicate(): After the existing check for both sides being non-null, added logic that returns the single convertible side when:AND(notOR)NOTexpression (De Morgan safety:NOT(AND(a,b)) = OR(NOT(a), NOT(b)))Added comprehensive tests in
IcebergExprVisitorTest:AND(convertible, unconvertible)returns the convertible sideAND(unconvertible, convertible)returns the convertible sideOR(convertible, unconvertible)still returns null (no partial pushdown)NOT(AND(convertible, unconvertible))returns null (De Morgan safety)AND(convertible1, convertible2)still returnsand(left, right)(regression)AND(AND(convertible, unconvertible), convertible2)returnsand(convertible, convertible2)Fixes #70292
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #70293 done by [Mergify](https://mergify.com).