Show peak PCIe RX/TX throughput in the device header#482
Open
Basavaraja-MS wants to merge 1 commit into
Open
Conversation
Track the maximum PCIe receive and transmit throughput observed since launch and display it next to the instantaneous values, e.g. "RX: 1.2 GiB/s (max 57.5 GiB/s)". This makes transient transfer peaks visible at a glance when diagnosing bus bottlenecks. The PCIe header field is widened to fit the additional value. The peak is reset only when nvtop restarts. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks the maximum PCIe RX and TX throughput observed since launch and displays it next to the instantaneous values in the device header:
This makes transient transfer peaks visible at a glance when diagnosing bus bottlenecks, without having to watch the live value.
pcie_rx_peak/pcie_tx_peaktostruct device_window(zero-initialized via the existingcalloc; they persist across terminal resize since the struct isn't reallocated).print_pcie_throughput_with_peak()helper used for both directions (removes the prior copy-paste).Note: header width
The PCIe header field is widened (46 → 88 columns) to fit the extra value, which increases each device panel's width. On a single wide terminal this is fine; on narrow or dense multi-GPU layouts it reduces how many panels fit per row. This is why the change is split out from the chart feature (#268 / the companion PR). Happy to make it opt-in via a config toggle if preferred.
Made with Cursor