Skip to content

Forward external plugin trigger RPCs#321

Open
haos666 wants to merge 1 commit into
TabularisDB:mainfrom
haos666:haos666/plugin-trigger-rpc-forwarding
Open

Forward external plugin trigger RPCs#321
haos666 wants to merge 1 commit into
TabularisDB:mainfrom
haos666:haos666/plugin-trigger-rpc-forwarding

Conversation

@haos666

@haos666 haos666 commented Jun 12, 2026

Copy link
Copy Markdown

Summary

Follow-up to #316 and the runtime companion change for #317.

  • Forward external plugin trigger RPCs through RpcDriver: get_triggers, get_trigger_definition, create_trigger, and drop_trigger.
  • Add RpcDriver unit tests covering method names, params, and result shapes.
  • Keep built-in driver trigger behavior unchanged; this only fills the external plugin adapter methods that currently fall back to the default unsupported implementation.

Validation

  • pnpm run typecheck
  • pnpm run lint
  • cargo test plugins::driver::tests -- --nocapture
  • cargo test --lib
  • Local DM plugin smoke: listed triggers, viewed definitions, created a trigger, and dropped a trigger through the Tabularis UI.

@kilo-code-bot

kilo-code-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • src-tauri/src/plugins/driver.rs - Adds get_triggers, get_trigger_definition, create_trigger, and drop_trigger RPC forwarding methods for external plugins, plus unit tests covering all four methods.

Reviewed by kimi-k2.6-20260420 · 613,769 tokens

@debba debba requested review from NewtTheWolf and debba June 15, 2026 19:59
@debba

debba commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

LGTM.
@NewtTheWolf if you want to do a check for new registry compliance.

@NewtTheWolf

Copy link
Copy Markdown
Collaborator

LGTM. @NewtTheWolf if you want to do a check for new registry compliance.

will do it tomorrow!

@debba

debba commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@saurabh500 following #268, this could be interesting for SQL Server integration too.

@NewtTheWolf

Copy link
Copy Markdown
Collaborator

@debba — registry-compliance check done 👍

This is fine from the registry side: the new tabularium-extensions.schema.json (in #299) already defines the triggers capability (capabilities.triggers"Enable trigger listing and management"), so a plugin exposing these forwarded trigger RPCs can declare support in a schema-compliant way. Nothing to change in #321 for compliance — it's good to go.

One cross-PR note: the only registry-side piece here is that schema, which lives in #299. So as long as it's just the schema change, #321 is fine — but the hosted registry needs to be brought in line with it before #299 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants