docs(svelte): add Form Composition guide and example to site nav#2138
Conversation
Both docs/framework/svelte/guides/form-composition.md and examples/svelte/large-form/ already exist (added in TanStack#1713) but were never wired into docs/config.json, so they don't appear on the website.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation configuration file was updated to include two new navigation routes for Svelte documentation: a guide on form composition and an example of a large form. No functional code logic was altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 91346dd
☁️ Nx Cloud last updated this comment at |
|
Thanks! |
@LeCarbonator any interest in the prevent orphaned docs in the future script? I can open a PR if so |
Contributions are always welcome! However, for this case, it would be better to include it in TanStack Config so that form isn't the only one with the orphaned docs guard. It could also be that form simply missed out on such a feature and had those docs slip by accidentally. Either way, I'll bring it up to the config maintainers. |
🎯 Changes
Add the Svelte "Form Composition" guide and "Large Form" example to the docs site navigation.
Both
docs/framework/svelte/guides/form-composition.mdandexamples/svelte/large-form/already exist (added in #1713) but were never added todocs/config.json, so they don't appear on the website.This brings Svelte in line with React, Angular, and Solid which all have their Form Composition guide and example listed.
Note: other orphaned docs
While investigating this, I found 39 total doc files across all frameworks that exist on disk but aren't wired into
docs/config.json. This PR only addresses the Svelte gaps, but here's the full picture:Guides missing from nav:
angular/guides/listeners.mdangular/guides/submission-handling.mdsolid/guides/devtools.mdsolid/guides/submission-handling.mdvue/guides/listeners.mdvue/guides/submission-handling.mdAuto-generated API reference docs missing from nav (32 files):
Spread across React (13), Solid (13), Angular (3), and Vue (4) — mostly newer API surface like
createFormHook,WithFormProps,useFieldGroup, etc.Happy to open follow-up PRs for those if helpful.
✅ Checklist
pnpm test:pr.🚀 Release Impact
💡 Idea: prevent orphaned docs in the future
The existing
test:docsscript (scripts/verify-links.ts) checks that links inside markdown files are valid, but it doesn't check the reverse — that doc files on disk have a corresponding entry indocs/config.json. That's how these slipped through.A small addition to
verify-links.ts(or a separate script added to thetest:docstarget) could catch this:Would that be useful? Happy to open a follow-up PR if so.
Summary by CodeRabbit