Potential fix for code scanning alert no. 30: Clear-text logging of sensitive information#46
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TeaEntityLab/teaAgent/security/code-scanning/30
To fix this without changing core functionality, ensure output is strictly allowlisted rather than relying only on key-name heuristics. The best approach here is to harden
_print_jsonso it only emits safe structural data and replaces leaf scalar values with a placeholder, while still preserving object shape for CLI usability. This prevents accidental clear-text disclosure regardless of key naming.In
teaagent/cli/_handlers/_mcp_trust.py, update the_print_jsonfunction internals by adding a local helper that recursively masks scalar values (str,int,float,bool,None) as"[REDACTED]", while preserving dict/list structure. Then dump that masked structure. Keep_strip_sensitive_fieldsand_redact_sensitivein the pipeline (defense in depth), but ensure final printed payload is non-sensitive by construction.No new imports or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.