netifd-morse: fix HaLow Mesh broken - #1269
Open
ian77chen wants to merge 1 commit into
Open
Conversation
root casue: netifd re-runs drv_morse_setup while the first bring-up is still settling. The second run's morse_interface_cleanup() removes interfaces while the mesh interface is mid-scan. In the driver, both morse_mac_ops_remove_interface() (mac.c:2785) and morse_mac_ops_sw_scan_complete() (mac.c:3680) hold mors->lock while waiting on a firmware command (600ms x 2 retries). They stall each other. The firmware stops responding after receiving the teardown sequence while still in scan mode, every subsequent command returns -110, and halow_mesh can never be brought up. solution: morse_interface_cleanup(): abort any in-progress scan before removing interfaces, so sw_scan_complete releases mors->lock immediately and rm_if no longer overlaps with it. drv_morse_setup(): add the missing 'channel' to json_get_vars. $channel was empty in _get_regulatory() and the hostapd conf. Fixes: WIFI-15668 Signed-off-by: Ian Chen <ian77_chen@accton.com>
✅ PR & Commit Guidelines — all checks passedCommits, PR description, and C style all look good. Thanks! Commit hygieneNo issues found. C styleNo issues found. PR description (ticket link)No issues found. See OPENWIFI_PR_GUIDELINES.md and OPENWIFI_CODING_GUIDELINES.md. Items marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root casue:
netifd re-runs drv_morse_setup while the first bring-up is still settling. The second run's morse_interface_cleanup() removes interfaces while the mesh interface is mid-scan.
In the driver, both morse_mac_ops_remove_interface() (mac.c:2785) and morse_mac_ops_sw_scan_complete() (mac.c:3680) hold mors->lock while waiting on a firmware command (600ms x 2 retries). They stall each other. The firmware stops responding after receiving the teardown sequence while still in scan mode, every subsequent command returns -110, and halow_mesh can never be brought up.
solution:
morse_interface_cleanup(): abort any in-progress scan before removing interfaces, so sw_scan_complete releases mors->lock immediately and rm_if no longer overlaps with it.
drv_morse_setup(): add the missing 'channel' to json_get_vars. $channel was empty in _get_regulatory() and the hostapd conf.
Fixes: WIFI-15668