修正 iPad 从竖屏到横屏的画面问题#121
Open
imneway wants to merge 2 commits intoThe-Fried-Fish:Integrationfrom
Open
Conversation
…creen width when rotating the iPad from portrait to landscape mode.
Collaborator
|
这个不错, 我有空看看 |
Collaborator
我看了一下这个PR的处理方式, 开始串流之前强制按长边为宽, 短边为高 提交分辨率, 如果按该PR直接合并, 会导致真正有竖屏串流需求的用户, 无法向sunshine发起 真正的竖屏分辨率请求(比如 1080*1920), sunshine无法分配一个 高比宽更长的分辨率。 也就是说,你看到的竖屏转横屏分辨率变小, 恰恰是 竖屏串流画面未经裁剪、旋转后完整呈现的 正确行为, 只不过因为你的PC画面实际是宽比高长的横屏画面,而设定的串流分辨率是 高比宽长。 完整的旋转后,长高度完整塞进了短高度, 导致上下左右都有黑边。 假设竖屏状态下PC画面已经填满整个高度, 旋转后只会有左右黑边, 你就不会觉得这样处理有什么问题了 |
Collaborator
|
会考虑后续做成一个选项, 决定串流时如何提交分辨率 |
Author
|
确实,我是以游戏串流来思考的,忽略了竖屏画面情况。加一个选项好些,或者加一个「串流竖屏」的 switch |
28e2f13 to
4a9e109
Compare
b20d6f1 to
5c646ef
Compare
9e6c22a to
138658c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正了两个问题:
另外 iPhone 上逻辑不太一样,而且也没有旋转屏幕需求,仍保留原逻辑不变。