Add transformations#34
Open
Rinceri wants to merge 38 commits into
Open
Conversation
Thrill12
reviewed
May 8, 2026
|
|
||
| sprite.Shader.Use(); | ||
|
|
||
| Camera.SetCameraThisFrame(windowSize, sprite.Entity.Transform._GetTransformation(elapsedTime), sprite.Shader); |
Thrill12
reviewed
May 8, 2026
| -hw, | ||
| -hh, | ||
| 0.0f, // BL (repeated) | ||
| leftX, bottomY, 0, // BL |
Thrill12
reviewed
May 8, 2026
| return Matrix4.LookAt(CameraPosition, CameraPosition + front, up); | ||
| } | ||
|
|
||
| public static void SetCameraPosition(float x, float y) |
Owner
There was a problem hiding this comment.
can probably just rename to SetPosition, since calling Camera.SetCameraPosition is a bit verbose
Thrill12
reviewed
May 8, 2026
|
|
||
| public static class Camera | ||
| { | ||
| public static Vector3 CameraPosition { get; private set; } = new(0.0f, 0.0f, 3.0f); |
Owner
There was a problem hiding this comment.
We should stop exposing types from OpenTK, as ideally we would want users to only have to depend on us, not also on OpenTK. See #26 for where i copy the Keys enum so that we don't use the one from OpenTK.
Would be worth extracting to our own Vector3 class AFTER this story is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8
WIP