Fix YAML output escaping emoji and supplementary-plane Unicode (#437)#549
Open
TomWright wants to merge 2 commits into
Open
Fix YAML output escaping emoji and supplementary-plane Unicode (#437)#549TomWright wants to merge 2 commits into
TomWright wants to merge 2 commits into
Conversation
Post-process yaml.Marshal output to unescape \UNNNNNNNN sequences back to UTF-8 for supplementary-plane characters (U+10000–U+10FFFF). The upstream yaml library's isPrintable does not handle 4-byte UTF-8, causing all such characters to be escaped.
|
Hi @TomWright go-yaml maintainer here (cc @ingydotnet) If you found an issue with the go-yaml library, please open an issue for it on the go-yaml repository |
Owner
Author
|
Thanks @ccoVeille, I've raised an issue here: yaml/go-yaml#354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-process yaml.Marshal output to unescape \UNNNNNNNN sequences back to UTF-8 for supplementary-plane characters (U+10000–U+10FFFF). The upstream yaml library's isPrintable does not handle 4-byte UTF-8, causing all such characters to be escaped.
Fixes #437