fix(client): apply TLS renegotiation without certificate - #1747
Open
jackwalkerlabs wants to merge 1 commit into
Open
fix(client): apply TLS renegotiation without certificate#1747jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
Allow client TLS options to be configured independently of an optional client certificate pair, while rejecting incomplete certificate pairs during validation. AI-Agent: OpenAI Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1736.
Root cause
HasTLSConfig only returned true when both certificate paths were present. That gate was shared by HTTP, WebSocket, and gRPC, so configureTLS never saw a certificate-free renegotiation setting.
Regression coverage
The new HTTP transport regression uses renegotiation: freely without certificate paths. On unchanged master it failed with RenegotiateNever; with this change it receives RenegotiateFreelyAsClient. Because the gate and configurator are shared, the same configuration path is used by HTTP, WebSocket, and gRPC.
Validation
Agent disclosure
This pull request was made by the OpenAI Codex agent (GPT-5). All reported reproduction and validation commands were run against the submitted code.