[UUM-141406] fixing action overlay behavior

Editor/MenuActions/Geometry/BevelEdges.cs

@@ -61,6 +61,16 @@
                     PreviewActionManager.UpdatePreview();
                 }
             });
+
+            System.Action onDelayedPreviewChanged = () =>
+            {
+                floatField.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
             root.Add(floatField);
 
             return root;

Editor/MenuActions/Geometry/ExtrudeEdges.cs

@@ -53,6 +53,16 @@
             floatField.tooltip = "Extrude Amount determines how far an edge will be moved along it's normal when extruding. This value can be negative.";
             floatField.SetValueWithoutNotify(m_ExtrudeEdgeDistance);
             floatField.RegisterCallback<ChangeEvent<float>>(OnExtrudeChanged);
+
+            System.Action onDelayedPreviewChanged = () =>
+            {
+                floatField.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
             root.Add(floatField);
 
             return root;

Editor/MenuActions/Geometry/ExtrudeFaces.cs

@@ -106,6 +106,16 @@
             });
             root.Add(distanceField);
 
+            System.Action onDelayedPreviewChanged = () =>
+            {
+                distanceField.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
+
             return root;
         }
 

Editor/MenuActions/Geometry/OffsetElements.cs

@@ -51,9 +51,9 @@
 
             var spaceField = new EnumField("Coordinate Space", coord);
             root.Add(spaceField);
-            spaceField.RegisterCallback<ChangeEvent<string>>(evt =>
+            spaceField.RegisterCallback<ChangeEvent<Enum>>(evt =>
             {
-                Enum.TryParse(evt.newValue, out CoordinateSpace newValue);
+                CoordinateSpace newValue = (CoordinateSpace)evt.newValue;
                 if (s_CoordinateSpace.value == newValue)
                     return;
                 s_CoordinateSpace.SetValue(newValue);
@@ -62,15 +62,24 @@
 
             var distField = new Vector3Field("Translate");
             distField.SetValueWithoutNotify(dist);
-            if(PreviewActionManager.delayedPreview)
-                distField.Query<FloatField>().ForEach(ff => ff.isDelayed = true);
+            distField.Query<FloatField>().ForEach(ff => ff.isDelayed = PreviewActionManager.delayedPreview);
             root.Add(distField);
             distField.RegisterCallback<ChangeEvent<Vector3>>(evt =>
             {
                 s_Translation.SetValue(evt.newValue, true);
                 PreviewActionManager.UpdatePreview();
             });
 
+            Action onDelayedPreviewChanged = () =>
+            {
+                distField.Query<FloatField>().ForEach(ff => ff.isDelayed = PreviewActionManager.delayedPreview);
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
+
             return root;
         }
 

Editor/MenuActions/Geometry/SubdivideEdges.cs

@@ -83,6 +83,15 @@
             m_SubdivCount.tooltip = tooltip;
             m_SubdivCount.RegisterCallback<ChangeEvent<int>>(OnCountChanged);
             m_SubdivCount.style.width = 40;
+            Action onDelayedPreviewChanged = () =>
+            {
+                m_SubdivCount.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
             line.Add(foldout);
             line.Add(m_Slider);
             line.Add(m_SubdivCount);

Editor/MenuActions/Geometry/WeldVertices.cs

@@ -69,6 +69,15 @@
                     m_WeldDistance.SetValue(evt.newValue);
                 PreviewActionManager.UpdatePreview();
             });
+            Action onDelayedPreviewChanged = () =>
+            {
+                floatField.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
             root.Add(floatField);
             return root;
         }

Editor/MenuActions/Selection/GrowSelection.cs

@@ -85,7 +85,15 @@
                 m_GrowSelectionAngleIterative.SetValue(evt.newValue);
                 PreviewActionManager.UpdatePreview();
             });
-
+            System.Action onDelayedPreviewChanged = () =>
+            {
+                floatField.isDelayed = PreviewActionManager.delayedPreview;
+            };
+            PreviewActionManager.delayedPreviewChanged += onDelayedPreviewChanged;
+            root.RegisterCallback<DetachFromPanelEvent>(evt =>
+            {
+                PreviewActionManager.delayedPreviewChanged -= onDelayedPreviewChanged;
+            });
             return root;
         }
 

Editor/Overlays/ActionSettings.cs

@@ -18,6 +18,7 @@
         [UserSetting("Mesh Editing", "Auto Update Action Preview", "Automatically update the action preview, without delay. This operation is costly and can cause lag when working with large selections.")]
         static Pref<bool> s_AutoUpdatePreview = new Pref<bool>("editor.autoUpdatePreview", false, SettingsScope.Project);
         internal static bool delayedPreview => !s_AutoUpdatePreview.value;
+        public static event Action delayedPreviewChanged;
 
         MenuAction m_CurrentAction;
 
@@ -59,8 +60,10 @@
             ProBuilderEditor.selectModeChanged += SelectModeChanged;
 
             SceneView.AddOverlayToActiveView(m_Overlay = new MenuActionSettingsOverlay());
+            // Hack to ensure that the overlay is displayed in the sceneview even when the overlay was already displayed before
+            // Doing only displayed = true is not adding the overlay as it should in the view, only changing the display status is
+            m_Overlay.displayed = false;
             m_Overlay.displayed = true;
-            SceneView.RepaintAll();
         }
 
         public void Dispose()
@@ -104,12 +107,7 @@
 
             s_AutoUpdatePreview.value = value;
 
-            if (s_Instance == null)
-                return;
-
-            SceneView.RemoveOverlayFromActiveView(s_Instance.m_Overlay);
-            SceneView.AddOverlayToActiveView(s_Instance.m_Overlay = new MenuActionSettingsOverlay());
-            s_Instance.m_Overlay.displayed = true;
+            delayedPreviewChanged?.Invoke();
         }
 
         internal static void EndPreview()