Skip to content

[UUM-136930] Fix Arch field not readable #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lopezt-unity wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[UUM-136930] Fix Arch field not readable #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cd1b56
givce more space to the UI labels
lopezt-unity Jun 1, 2026
d508aa8
shorten the label for arch as it's done for the torus
lopezt-unity Jun 1, 2026
616d1f2
changelog
lopezt-unity Jun 1, 2026
dc204fa
removed undesired code
lopezt-unity Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Changes

- [UUM-136930] Fixed Arch circumference field not being fully readable in the editor.
- [UUM-131032] Added a reset of static variables when entering playmode to allow fast enter playmode compatibility.
- [UUM-138539] Removed the pb_ObjectArray file that was deprecated 8 years ago and is not used amymore.
- [UUM-138960] Removed a large utility dictionary to reduce binary size and runtime memory overhead.
Expand Down
2 changes: 1 addition & 1 deletion Editor/EditorCore/ProBuilderShapeEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
if(foldoutEnabled)
{
EditorGUI.indentLevel++;
EditorGUIUtility.labelWidth = 90;
EditorGUIUtility.labelWidth = 120;

Check warning on line 136 in Editor/EditorCore/ProBuilderShapeEditor.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Editor/EditorCore/ProBuilderShapeEditor.cs#L136 

Added line #L136 was not covered by tests

if (tool)
tool.pivotLocation = (PivotLocation)EditorGUILayout.EnumPopup(k_ShapePivotLabel, tool.pivotLocation);
Expand Down
2 changes: 1 addition & 1 deletion Runtime/Shapes/Arch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@

static readonly GUIContent k_ThicknessContent = new GUIContent("Thickness", L10n.Tr("Thickness of the arch borders. Larger value creates a smaller opening."));
static readonly GUIContent k_SidesContent = new GUIContent("Sides Count", L10n.Tr("Number of sides of the arch."));
static readonly GUIContent k_CircumferenceContent = new GUIContent("Arch Circumference", L10n.Tr("Circumference of the arch in degrees."));
static readonly GUIContent k_CircumferenceContent = new GUIContent("Arch Circ.", L10n.Tr("Circumference of the arch in degrees."));

Check warning on line 221 in Runtime/Shapes/Arch.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Runtime/Shapes/Arch.cs#L221 

Added line #L221 was not covered by tests
static readonly GUIContent k_EndCapsContent = new GUIContent("End Caps", L10n.Tr("Whether to generate faces for the ends of the arch."));
static readonly GUIContent k_SmoothContent = new GUIContent("Smooth", L10n.Tr("Whether to smooth the edges of the arch."));

Expand Down