refactor: refactor payjoin receiver poller#23
Draft
ValeraFinebits wants to merge 2 commits into
Draft
Conversation
ValeraFinebits
changed the base branch from
master
to
feat/improve-error-handling
ValeraFinebits
force-pushed
the
refactor/Refactor-PayjoinReceiverPoller
branch
from
ce93eef to
3be9840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #20 and should be merged after it.
Refactored the payjoin receiver pipeline to break the old
PayjoinReceiverPollermonolith into focused, testable services while preserving behavior.What changed
PayjoinReceiverPollerto a thin hosted workerPayjoinReceiverSessionProcessorNew services
PayjoinReceiverSessionGuardPayjoinReceiverRelayClientPayjoinReceiverStateProcessorPayjoinReceiverOutputBuilderPayjoinReceiverInputSelectorPayjoinReceiverProposalFinalizerOther updates
Notes
This PR is primarily a structural refactor. One intentional nuance is that expired sessions are now filtered by the session guard earlier in the processing flow, which is acceptable and keeps cleanup responsibility in one place.