Conversation
…x incorrect sample initialization from a rotated VideoFrame, and fix a few other things
Preserve rotation when calling `.toVideoFrame()`
- Add extensive tests for packet cursor, sample cursor, and call serialization - Major PacketCursor refactor - Add PacketReader - Many SampleCursor fixes, harden the behavior - Typo fixes and various other small things
…t, add sample mapping, and a bunch of extra shit I forgot
…rder in which they are queued
… more cursor tests
…d MP3 reading tests
…, add packet internal data, and various other fixes prob
…se cursors, remove setTimestamp, setDuration and setDuration on samples, add sample clone override options, optimize async mutex
|
Is there a way to test it already? |
Owner
Author
|
It's been about ~1.5 months since I last touched this branch, but I think the cursor stuff is pretty much ready. You can clone that branch and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current changes (in no specific order):
VideoSamplenow respects therotationfield of the underlyingVideoFrameand properly sets it when creating frames via.toVideoFrame(). BREAKING CHANGE: TheVideoFramereturned by.toVideoFrame()now has the same rotation as theVideoSample(previously, it was always unrotated)