Skip to content

Fix for https://github.com/Vendicated/Vencord/issues/3691#4387

Open
meowpurrpur wants to merge 4 commits into
Vendicated:mainfrom
meowpurrpur:fix-stickerpaste-fakenitro
Open

Fix for https://github.com/Vendicated/Vencord/issues/3691#4387
meowpurrpur wants to merge 4 commits into
Vendicated:mainfrom
meowpurrpur:fix-stickerpaste-fakenitro

Conversation

@meowpurrpur

Copy link
Copy Markdown

Describe your Changes

Fixes #3691

StickerPaste already handles sending stickers later, so FakeNitro shouldn't call promptToUpload and upload the generated GIF a second time. Pasted stickers now get attached to the current send options instead. I have no idea if there's a better way to do this but it doesn't seem like it as I tried a few different fixes.

Checklist before submitting

  • I have read the CONTRIBUTING.md file and made sure this pull request complies with it
  • This pull request was written by me, and not an AI agent

@sadan4 sadan4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is incorrect and breaks if the user uploads a sticker and a attachment at the same time. The sticker is omitted.

Comment thread src/api/MessageEvents.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collison bewteen FakeNitro and StickerPaste

2 participants