Fix cluster non default additional service when lb enabled#2137
Open
AndrewChubatiuk wants to merge 2 commits intomasterfrom
Open
Fix cluster non default additional service when lb enabled#2137AndrewChubatiuk wants to merge 2 commits intomasterfrom
AndrewChubatiuk wants to merge 2 commits intomasterfrom
Conversation
AndrewChubatiuk
force-pushed
the
fix-cluster-non-default-additional-service-when-lb-enabled
branch
2 times, most recently
from
bbcf893 to
bb9da70
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…al-service when useAsDefault: false
AndrewChubatiuk
force-pushed
the
fix-cluster-non-default-additional-service-when-lb-enabled
branch
from
bb9da70 to
8392e16
Compare
vrutkovs
approved these changes
May 7, 2026
…-when-lb-enabled Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed infinite recreation of non-default additional select/insert service when requestsLoadBalancer.enabled: true
Summary by cubic
Fixes infinite recreation of non-default additional Select/Insert Services across
VMCluster,VLCluster, andVTClusterwhenrequestsLoadBalancer.enabledis true anduseAsDefault: false. Aligns LB proxy selectors and service generation to avoid name clashes and reconcile loops.cr.PrefixedName(...)) to avoid name collisions.r.SelectorLabelsfor the balancer selector across clusters.Written for commit 660e583. Summary will update on new commits.