vmagent: support per remoteWrite queues configuration

[AndrewChubatiuk]

fixes #2138

---

Summary by cubic

Adds per-remoteWrite queues configuration to VMAgent, letting you set different queue counts per remote write target with fallback to the global setting.

• New Features
  • Added queues to VMAgentRemoteWriteSpec; CRD and docs updated.
  • Controller builds -remoteWrite.queues per URL; if any per-target is set, emits a list; otherwise uses remoteWriteSettings.queues.

^{Written for commit 12c7c04. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/vmagent/vmagent.go">

<violation number="1" location="internal/controller/operator/factory/vmagent/vmagent.go:1030">
P1: `hasAnyQueuesSet` is set too broadly, which can drop `-remoteWrite.queues` entirely when explicit per-URL values equal the global queue value.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P1: hasAnyQueuesSet is set too broadly, which can drop -remoteWrite.queues entirely when explicit per-URL values equal the global queue value.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At internal/controller/operator/factory/vmagent/vmagent.go, line 1030:

<comment>`hasAnyQueuesSet` is set too broadly, which can drop `-remoteWrite.queues` entirely when explicit per-URL values equal the global queue value.</comment>

<file context>
@@ -1017,6 +1025,12 @@ func buildRemoteWriteArgs(cr *vmv1beta1.VMAgent, ac *build.AssetsCache) ([]strin
 			}
+			if rw.Queues != nil {
+				queuesPerRW = append(queuesPerRW, strconv.Itoa(int(*rw.Queues)))
+				hasAnyQueuesSet = true
+			} else {
+				queuesPerRW = append(queuesPerRW, queues)
</file context>

[AndrewChubatiuk]

there's no need in per url values in this case

[cubic-dev-ai]

Got it, thanks for clarifying.