feat(dashboard variables): allow custom values#606
feat(dashboard variables): allow custom values#606github-vincent-miszczak wants to merge 5 commits intoVictoriaMetrics:mainfrom
Conversation
af33c3b to
7d2ed28
Compare
|
@arturminchukov , thank you very much for the review. |
|
I've tested it locally. Looks like it doesn't work as expected and do not change the value in Combobox, because Grafana's Combobox do not call Maybe you can change to deprecated |
There was a problem hiding this comment.
1 issue found across 21 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/language_provider.ts">
<violation number="1" location="src/language_provider.ts:112">
P2: getStreamFieldList ignores fieldValueFilter, so stream field value searches won’t be server-side filtered (unlike getFieldList), causing unfiltered/large results and broken search behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
83ae820 to
9b7852d
Compare
|
@arturminchukov my update using |
Signed-off-by: Artur Minchukou <aminchukov@victoriametrics.com>
arturminchukov
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing!
|
@github-vincent-miszczak Could you please sign your commits? Here, you can find a guide on how to do it. |
When working with dashboard variables, fields do not necessarily exist at the time of creation/manipulation(when importing a dashboard from JSON for instance, then editing a variable).
This feature keeps the existing behavior, but also allows custom values from user or JSON.
Summary by cubic
Enable custom field names in the dashboard variable editor so variables work even when the field doesn’t exist yet (e.g., after importing from JSON). Replaces the field dropdown with a
CompatibleComboboxthat supports freeform entries and better loading UX.CompatibleCombobox(wrapper around@grafana/uiCombobox) with custom values viacreateCustomValue/onCreateOption.loading, keeps listing fetched fields, forwardsonBlur.onChangewith updatedtype,field,query, andlimit.fieldNamesto{ value, label, description? }; updated CHANGELOG.Written for commit f06426c. Summary will update on new commits.