Stream filters enhancement#629
Open
arturminchukov wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
3 issues found across 22 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/shared/Chip/Chip.tsx">
<violation number="1" location="src/components/shared/Chip/Chip.tsx:64">
P2: Make the value span non-inline before using `max-width`/`text-overflow`; otherwise the ellipsis truncation won't work and long values can overflow the chip.</violation>
</file>
<file name="src/components/QueryEditor/StreamFilters/StreamLabelList.tsx">
<violation number="1" location="src/components/QueryEditor/StreamFilters/StreamLabelList.tsx:52">
P2: Initial stream-label loading has no failure handling, and the called loader can remain pending on fetch errors. This can leave the sidebar stuck without updating after a failed request.</violation>
</file>
<file name="src/components/shared/CopyButton/CopyButton.tsx">
<violation number="1" location="src/components/shared/CopyButton/CopyButton.tsx:64">
P2: Avoid calling `navigator.clipboard.writeText` directly here; it bypasses Grafana's clipboard fallback, so icon-only copy can fail in insecure contexts or browsers without the Clipboard API.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
22df1d9 to
d7b495a
Compare
dmitryk-dk
reviewed
Apr 28, 2026
dmitryk-dk
reviewed
Apr 28, 2026
dmitryk-dk
reviewed
Apr 28, 2026
Contributor
|
I love the initiative! But pretty much concerned with the amount of empty space it introduces below the query area. We should think of minimizing that unused space. |
Loori-R
approved these changes
Apr 30, 2026
dmitryk-dk
approved these changes
May 6, 2026
Add overflow: hidden to the Monaco query field container so its inner viewport does not paint over the rounded corners of the outer border.
The ignore_pipes=1 query arg is needed in order to ignore pipes in the query when returning the list of log stream field names and values.
2dc8ab0 to
df920a3
Compare
- Stream filters now live in a dedicated sidebar instead of an inline
form above the query — labels stay visible while you edit the
expression, with no extra scrolling
- Sidebar fits Explore's vertical layout, so adding more filters no
longer pushes the query field down
- Header exposes one-click actions: clear-all and copy-as-LogsQL for
the whole filter set
- Selected values render as chips under the query — active streams are
visible at a glance without expanding each filter row
df920a3 to
3b4ce76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Add stream filters as a sidebar. It makes it easy to see which stream names exist and provides a simpler way to interact with them.
Screen.Recording.2026-05-08.at.13.52.52.mov
Checklist
The following checks are mandatory:
Summary by cubic
Moves stream filters into a toolbar with a popover for browsing labels and values. Selected values show as removable chips under the query. Suggestions respect the current selection and ignore pipes; filters work in both code and builder modes.
New Features
extra_stream_filters(labels reflect full selection; the value panel ignores its own label) and ignore pipes viaignore_pipes=1.Refactors
StreamFiltersProviderand hooks (useStreamFilters,useFetchedValues, updateduseFetchStreamFilters); replaced old inline filters with the bar + popover.CopyButtonandChip; improved value escaping and moved stream filter utils.IgnorePipesto fields queries and wired through thelanguage_provider.inonly; clipped Monaco query field content to rounded borders.Written for commit 3b4ce76. Summary will update on new commits.